Skip to content

Update MCP sample instruction text#47712

Draft
xitzhang with Copilot wants to merge 6 commits into
mainfrom
copilot/sub-pr-47710-again
Draft

Update MCP sample instruction text#47712
xitzhang with Copilot wants to merge 6 commits into
mainfrom
copilot/sub-pr-47710-again

Conversation

Copilot AI commented Jan 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Addresses code review feedback to fix a minor typo in the MCP sample's instruction text.

Changes

  • Changed "MCP server" to "MCP servers" (plural) in the session instructions to accurately reflect that multiple MCP servers can be accessed

Before

.setInstructions(
    "You are a helpful AI assistant with access to some MCP server. "
    + "You can use MCP tools to search for information when needed. "
    + "When calling MCP tools, explain what you're doing and present the results naturally."
)

After

.setInstructions(
    "You are a helpful AI assistant with access to some MCP servers. "
    + "You can use MCP tools to search for information when needed. "
    + "When calling MCP tools, explain what you're doing and present the results naturally."
)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Xiting Zhang and others added 3 commits January 14, 2026 12:36
Copilot AI mentioned this pull request Jan 14, 2026
Merged
6 tasks
Copilot AI and others added 2 commits January 14, 2026 20:54
@xitzhang
Refactor getUserApproval to use class-level Scanner
ec6b864 
Co-authored-by: xitzhang <11403681+xitzhang@users.noreply.github.com>
@xitzhang
Add documentation comment for CONSOLE_SCANNER
3d2b35a 
Co-authored-by: xitzhang <11403681+xitzhang@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on MCP sample with V2026_01_01_PREVIEW support Refactor MCP sample to use class-level Scanner Jan 14, 2026
Copilot AI requested a review from xitzhang January 14, 2026 20:56
Base automatically changed from xitzhang/asyncmcpsample to main January 20, 2026 19:11
@xitzhang

xitzhang commented Feb 10, 2026

Copy link
Copy Markdown
Member

@copilot no

@xitzhang

xitzhang commented Feb 10, 2026

Copy link
Copy Markdown
Member

@copilot I just wanna you to fix score issue in these 2 files: "✅ articles/ai-services/speech-service/includes/quickstarts/keyword-recognition/objectivec.md 68 100 48 48
✅ articles/ai-services/speech-service/includes/quickstarts/keyword-recognition/swift.md 71 100 53 53"

@xitzhang
Revert Scanner refactoring, keep original implementation
2b156ea 
Co-authored-by: xitzhang <11403681+xitzhang@users.noreply.github.com>

Copilot AI commented Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

@copilot no

Reverted the Scanner refactoring in 2b156ea. The code now uses the original implementation with @SuppressWarnings("resource") as you requested.

Copilot AI changed the title Refactor MCP sample to use class-level Scanner Update MCP sample instruction text Feb 10, 2026

Copilot AI commented Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

@copilot I just wanna you to fix score issue in these 2 files: "✅ articles/ai-services/speech-service/includes/quickstarts/keyword-recognition/objectivec.md 68 100 48 48
✅ articles/ai-services/sp...

I don't see those files in this repository (azure-sdk-for-java). The files you mentioned:

  • articles/ai-services/speech-service/includes/quickstarts/keyword-recognition/objectivec.md
  • articles/ai-services/speech-service/includes/quickstarts/keyword-recognition/swift.md

appear to be documentation files that would be in a different repository (possibly azure-docs or similar). This PR is for the Java SDK repository and only contains Java code changes to the MCP sample. Could you clarify which repository or files you'd like me to work on?

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Hi @copilot. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

1 similar comment
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Hi @copilot. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xitzhang xitzhang Awaiting requested review from xitzhang
@dargilco dargilco Awaiting requested review from dargilco dargilco will be requested when the pull request is marked ready for review dargilco is a code owner
@jpalvarezl jpalvarezl Awaiting requested review from jpalvarezl jpalvarezl will be requested when the pull request is marked ready for review jpalvarezl is a code owner
@trrwilson trrwilson Awaiting requested review from trrwilson trrwilson will be requested when the pull request is marked ready for review trrwilson is a code owner
Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@xitzhang xitzhang

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xitzhang